Converted jemalloc to submodule #65
Open
+5
−80,078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, will have a look at it! I was once thinking of using submodules, but have no experience with them in Git and as far as I remember - they're not as easy as Subversion's |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts
jemallocinto a submodule which prevents code copying and enables rebasing onjemalloc/jemallocand being able to benefit from bug fixes on that repo.This PR is not to be merged blindly, it removes the
jemalloccopy and replaces it with a submodule. The submodule currently points to my own fork oftporadowski/jemalloc-->paviad/jemallocand points to a commit which is based onjemallocmasterbranch and brings it to the same state as it was in the originaltporadowski/redis/developbranch.So if you want to use this PR, you should first create a
redisbranch ontporadowski/jemallocapply the 4 commits from theredisbranch ofpaviad/jemallocand then add it as a submodule.